better file path handling, fixed tests

3 files changed, 53 insertions, 51 deletions

diff --git a/src/db.rs b/src/db.rs
index 94642ce..79099b0 100644
--- a/src/db.rs
+++ b/src/db.rs
@@ -3,7 +3,7 @@ use directories::BaseDirs;
 use futures_util::Stream;
 use libsql::{Builder, Connection, params};
 use std::{
-    path::Path,
+    path::{Path, PathBuf},
     time::{Duration, UNIX_EPOCH},
 };
 
@@ -13,6 +13,7 @@ const TABLE_CREATE: &str = "CREATE TABLE IF NOT EXISTS flacs (path TEXT PRIMARY
 const ADD_NEW_ITEM: &str = "INSERT INTO flacs (path, toencode, modtime) VALUES (?1, ?2, ?3)";
 const REPLACE_ITEM: &str = "REPLACE INTO flacs (path, toencode, modtime) VALUES (?1, ?2, ?3)";
 const TOENCODE_QUERY: &str = "SELECT path FROM flacs WHERE toencode";
+const TOENCODE_NUMBER: &str = "SELECT COUNT(*) from flacs WHERE toencode";
 const CHECK_FILE: &str = "SELECT exists(SELECT 1 FROM flacs WHERE path = ?1)";
 const FETCH_MODTIME: &str = "SELECT modtime FROM flacs WHERE path = ?1";
 const FETCH_FILES: &str = "SELECT path FROM flacs";
@@ -34,7 +35,8 @@ impl Database {
     pub async fn insert_file(&self, filename: impl AsRef<Path>) -> Result<()> {
         let toencode = !matches!(get_vendor(&filename)?.as_str(), CURRENT_VENDOR);
 
-        let modtime = filename.as_ref()
+        let modtime = filename
+            .as_ref()
             .metadata()?
             .modified()?
             .duration_since(UNIX_EPOCH)?
@@ -51,7 +53,8 @@ impl Database {
     }
 
     pub async fn update_file(&self, filename: impl AsRef<Path>) -> Result<()> {
-        let modtime = filename.as_ref()
+        let modtime = filename
+            .as_ref()
             .metadata()?
             .modified()?
             .duration_since(UNIX_EPOCH)?
@@ -104,7 +107,7 @@ impl Database {
         self.0.execute(DEDUPE_DB, ()).await?;
         let mut query_res = self.0.query(FETCH_FILES, ()).await?;
         while let Ok(Some(row)) = query_res.next().await {
-            let path = Path::new(row.get_str(0)?).to_path_buf();
+            let path = PathBuf::from(row.get_str(0)?);
             let conn = self.0.clone();
             tasks.spawn(async move {
                 if !path.exists() {
@@ -117,7 +120,7 @@ impl Database {
 
         tasks.join_all().await;
 
-        self.0.execute("VACUUM;", ()).await?;
+        self.0.execute("VACUUM", ()).await?;
 
         Ok(())
     }
@@ -127,6 +130,17 @@ impl Database {
     ) -> Result<impl Stream<Item = libsql::Result<libsql::Row>>> {
         Ok(self.0.query(TOENCODE_QUERY, ()).await?.into_stream())
     }
+
+    pub async fn get_toencode_number(&self) -> Result<u64> {
+        Ok(self
+            .0
+            .query(TOENCODE_NUMBER, ())
+            .await?
+            .next()
+            .await?
+            .unwrap()
+            .get::<u64>(0)?)
+    }
 }
 
 pub async fn open_default_db() -> Result<Database> {
@@ -176,7 +190,9 @@ mod tests {
         let filenames = ["16bit.flac", "24bit.flac", "32bit.flac"];
         let conn = Database::new(&dbname).await.unwrap();
         for file in filenames {
-            let _ = conn.insert_file(&file.to_string()).await;
+            let _ = conn
+                .insert_file(Path::new(file).canonicalize().unwrap())
+                .await;
         }
 
         let _ = conn
@@ -195,7 +211,15 @@ mod tests {
             )
             .await;
 
-        conn.update_file(&"16bit.flac".to_string()).await.unwrap();
+        conn.update_file(
+            Path::new("16bit.flac")
+                .canonicalize()
+                .unwrap()
+                .to_str()
+                .unwrap(),
+        )
+        .await
+        .unwrap();
 
         let returned = conn
             .0
diff --git a/src/files.rs b/src/files.rs
index 045c5b4..a019cfb 100644
--- a/src/files.rs
+++ b/src/files.rs
@@ -36,10 +36,11 @@ impl Display for FileError {
     }
 }
 
-async fn handle_file(file: PathBuf, conn: Database) -> Result<()> {
+async fn handle_file(file: impl AsRef<Path>, conn: Database) -> Result<()> {
     match conn.check_file(&file).await {
         Ok(true) => {
             let modtime = file
+                .as_ref()
                 .metadata()?
                 .modified()?
                 .duration_since(UNIX_EPOCH)?
@@ -105,17 +106,7 @@ pub async fn index_files_recursively(path: impl AsRef<Path>, conn: &Database) ->
     Ok(())
 }
 
-fn check_path(folderpath: Option<&PathBuf>) -> Result<(PathBuf, bool)> {
-    if let Some(real_path) = folderpath {
-        Ok((real_path.canonicalize()?, false))
-    } else {
-        Ok((PathBuf::new(), true))
-    }
-}
-
-pub async fn reencode_files(folderpath: Option<&PathBuf>, conn: &Database) -> Result<()> {
-    let (path, nocheck) = check_path(folderpath)?;
-
+pub async fn reencode_files(conn: &Database) -> Result<()> {
     let stream = conn.get_toencode_stream().await?;
     pin_mut!(stream);
 
@@ -126,9 +117,7 @@ pub async fn reencode_files(folderpath: Option<&PathBuf>, conn: &Database) -> Re
     while let Some(Ok(row)) = stream.next().await {
         if let Some(file) = row.get_value(0)?.as_text() {
             let filename = Path::new(file).canonicalize()?;
-            if nocheck || filename.starts_with(&path) {
-                tasks.spawn_blocking(move || handle_encode(filename));
-            }
+            tasks.spawn_blocking(move || handle_encode(filename));
         }
     }
 
@@ -158,25 +147,6 @@ pub async fn reencode_files(folderpath: Option<&PathBuf>, conn: &Database) -> Re
     Ok(())
 }
 
-pub async fn count_reencode_files(folderpath: Option<&PathBuf>, conn: &Database) -> Result<u64> {
-    let (path, nocheck) = check_path(folderpath)?;
-
-    let mut counter: u64 = 0;
-    let stream = conn.get_toencode_stream().await?;
-    pin_mut!(stream);
-
-    while let Some(Ok(row)) = stream.next().await {
-        if let Some(file) = row.get_value(0)?.as_text() {
-            let filename = Path::new(file).canonicalize()?;
-            if nocheck || filename.starts_with(&path) {
-                counter += 1;
-            }
-        }
-    }
-
-    Ok(counter)
-}
-
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -191,15 +161,23 @@ mod tests {
         std::fs::remove_file("temp3.db").unwrap();
     }
 
-    #[tokio::test]
-    async fn test_reencode_lots_of_files() {
-        let conn = Database::new("temp4.db").await.unwrap();
-        let path = PathBuf::from("./testfiles");
-        index_files_recursively(Path::new("./testfiles"), &conn)
-            .await
+    #[test]
+    fn test_reencode_lots_of_files() {
+        let runtime = tokio::runtime::Builder::new_multi_thread()
+            .max_blocking_threads(4)
+            .enable_all()
+            .build()
             .unwrap();
-        println!("\n{}", count_reencode_files(None, &conn).await.unwrap());
-        reencode_files(Some(&path), &conn).await.unwrap();
+        runtime.block_on(async move {
+            let conn = Database::new("temp4.db").await.unwrap();
+            index_files_recursively(Path::new("./testfiles"), &conn)
+                .await
+                .unwrap();
+            println!("\n{}", conn.get_toencode_number().await.unwrap());
+            reencode_files(&conn).await.unwrap();
+            println!("\n{}", conn.get_toencode_number().await.unwrap());
+        });
+
         std::fs::remove_file("temp4.db").unwrap();
     }
 }
diff --git a/src/main.rs b/src/main.rs
index 5d3835f..da04a9e 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -90,7 +90,7 @@ fn main() -> Result<()> {
         let path = args.get_one::<PathBuf>("path");
 
         if path.is_none() && !args.get_flag("clean") && !args.get_flag("doit") {
-            let count = files::count_reencode_files(path, &conn).await.unwrap();
+            let count = conn.get_toencode_number().await?;
             println!("Files to reencode:\t{count}");
         } else if let Some(realpath) = path {
             if !args.get_flag("doit") {
@@ -103,7 +103,7 @@ fn main() -> Result<()> {
         }
 
         if args.get_flag("doit") {
-            files::reencode_files(path, &conn).await?;
+            files::reencode_files(&conn).await?;
         }
         Ok::<(), anyhow::Error>(())
     })?;